Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 30, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42733
Staging -
atlas setup
connections string setup

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit 44559fb
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/66fafea9e32a2800085db0df
😎 Deploy Preview https://deploy-preview-48--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@alexbevi alexbevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ a couple suggestions

@@ -0,0 +1,51 @@
You can connect to your MongoDB deployment by providing a
**connection URI**, also called a *connection string*, which
instructs {+odm+} on how to connect to a MongoDB deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: avoid 'on' to mean 'about'. open to other alternatives than this one

Suggested change
instructs {+odm+} on how to connect to a MongoDB deployment
tells {+odm+} how to connect to a MongoDB deployment

@@ -0,0 +1,22 @@
You can create a free tier MongoDB deployment on MongoDB Atlas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: compound adjective

Suggested change
You can create a free tier MongoDB deployment on MongoDB Atlas
You can create a free-tier MongoDB deployment on MongoDB Atlas

Comment on lines 11 to 12
guide to set up a new Atlas account and load sample data into a new free
tier MongoDB deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
guide to set up a new Atlas account and load sample data into a new free
tier MongoDB deployment.
guide to set up a new Atlas account and load sample data into a new free-
tier MongoDB deployment.

After you create your database user, save that user's
username and password to a safe location for use in an upcoming step.

After completing these steps, you have a new free tier MongoDB deployment on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After completing these steps, you have a new free tier MongoDB deployment on
After completing these steps, you have a new free-tier MongoDB deployment on

@rustagir rustagir merged commit 41d810b into mongodb:standardized Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants